dashCommerce

Please post any "replicatable" bugs in this thread and include as much detail as possible which will alow us to replicate and find the bug.

I will find and post bugs here for reference, I take not responsibility if the fixes do not work for you or cause you more problems.

UPDATE 23-Feb-2008: I'm now migrating some of my fixes to CodePlex which will allow the developers to integrate them more easily and for anyone to post questions regarding fixes. I'm also adding some fixes posted by others thanks for all your contributions.

1. Circular refrence on Product Catagories - FIX

2. Saving  SKUs for a product with no attributes - FIX

3. Admin products images page throws error when no images - FIX

4. Products without a pictures hiding the tabs in product page - FIX

5. Hitting enter after filling in login details doesnt run login button - FIX

6. Products page showing empty tabcontrol when no descriptors specified - FIX

7. System.Threading.ThreadAbortExceptions in rolelist.aspx.cs - FIX

8. Images are too big in catagories list - FIX

9. "My Cart" throws error if no shipping provider has been specified. FIX

10. Visiting a product page that does not exist displays an empty product page and logs a "System.DivideByZeroException: Attempted to divide by zero exception" Since the fix for this is allot bigger than my usual ones i've moved it to a seperet message.

 FIX:  http://dashcommerce.org/forums/p/80/487.aspx#487

11. mattschuett: "allow negative inventory" checkbox is not checked editing SKU - FIX

12. mattschuett: "add to cart" button disabled even when allow negative prodecut set to true - FIX

13. aewrigley: Quantity drop down list resetting on postback on attributes selector control - FIX DONT APPLY

14. Content Management aloows you to add a page causing a Circular refrence and breaking the ite completly - FIX

15. ebirbal: Hitting enter on manufacturers page text box causes the page to referesh instead of saving - FIX

16. It's possible to delete the last Content Page and break the site completly - FIX

17. Checkout page logging loads of ThreadAbortExceptions - FIX

18. yitzchok: imageselector.aspx Lets uploading all types of files and errors if older contain non-images - FIX

19. benm: Binding DropDownLists many times only needs to be done once - FIX

1. No Payment Provider Configured causes "My Cart" bug.

If you atttempt to go to your cart (with an item in it) without any of the payment providers configured you will receive an "Object Reference" error.

This is triggered by:

I took a look in dashCommerce_Core_ConfigurationData before and after I saved my Shipping General Setting and the "shippingServiceSettings" did not exist until after the save.  When saving your settings the entry is created regardless if "Use Shipping" is checked.  Should the basic shippingServices Settings be set to the default of SimpleWeightShippingProvider?  Or will unconfigured providers (tax and shipping) that are needed for checkout change the interface to reflect that they are not provided.

@Naz
2. Check this link

---------

I think that you will have to configure the payment provider before you can make a check out so thats the warning that you havn't set up the provider.

On Checkout.aspx at Billing Information If “Add New” is used there is no way to cancel out of creating a new billing address at checkout.

"A critical error has occurred: Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index" error occurs when you have no product images loaded against the product and click on the "Images" tab in the Edit Product section.

The Error is on line 343 of the images.ascx.cs file:       ImageButton lbUp = dgProductImages.Items[0].Cells[0].FindControl("lbUp") as ImageButton;

 And again on line 347: ImageButton lbDown = dgProductImages.Items[dgProductImages.Items.Count - 1].Cells[0].FindControl("lbDown") as ImageButton;

 Fix for this error is:

 if (dgProductImages.Items.Count > 0)
      {
          ImageButton lbUp = dgProductImages.Items[0].Cells[0].FindControl("lbUp") as ImageButton;
          if (lbUp != null)
          {
              lbUp.Visible = false;
          }
          ImageButton lbDown = dgProductImages.Items[dgProductImages.Items.Count - 1].Cells[0].FindControl("lbDown") as ImageButton;
          if (lbDown != null)
          {
              lbDown.Visible = false;
          }
      }

Cheers

Hugh

There is a little annoyance on the login page.

If you happen to hit enter after typing your password, it acts as if you hit the search button, not the login button.

Took me about 5 login tries before I realized what was happening.

Also, should we be adding these to the codeplex issue tracker? 

On the manufacturers page, pressing enter with the cursor in the text box causes the page to referesh, but the btnSave event does not get fired.

Fix:  In manufacturers.aspx, line 20 add DefaultButton="btnSave"

Line 20:      <asp:Panel ID="pnlAddManufacturer" runat="server" DefaultButton="btnSave">

This issue could possibly occur at several locations, so the general fix is to set the  "defaultbutton" property of the containing <asp:Panel /> or  <Form /> to the ID of the <asp:Button>, whose event you want to fire. The DefaultButton property can be set at the Form level in the form tag or at the panel level in the <asp:panel> tag. The form level setting is overridden when specified at the panel level, for those controls that are inside the panel

The text box to enter an image file (under the Images tab, productedit.aspx) needs a required field validator.

Currently it allows you to save a product image without entering a file name.

also the ". . ." link besides the text box could use some improvement... its barely visible

I really think  we should start logging bugs at codeplex... its gonna become a nightmare to keep track of all iss issues here

Of note:

Tax providers round the number up. For the UK as an example setting a rate of 0.175 will be 0.18 when saved. This does not happen for the default rate used if one is not found.

Anyone using a rate that has a .x value will find it rounded up. So 17.5% becomes 18% when calculated.

Regards,

Steve

I've updated my 1st post with some more bug fixes. 

@naz

 I can try this to fix my site, but aren't these fixes supposed to be available as patches?

Dave

Line 186 contains the following:

protected void btnSave_Click (object sender, EventArgs e) {

 Where in relation to this do we enter the fix:

if (associatedAttributeCollection != null && associatedAttributeCollection.Count > 0) CreateSkus(associatedAttributeCollection[0], 0, product.BaseSku);else skus.Add(product.BaseSku);

 Thanks,

Dave

I believe it goes like this:

line:186
    protected void btnSave_Click (object sender, EventArgs e) {
      try {
        SkuCollection skuCollection = new SkuCollection();
        Sku sku;

     if (associatedAttributeCollection != null && associatedAttributeCollection.Count > 0) CreateSkus(associatedAttributeCollection[0], 0, product.BaseSku);else skus.Add(product.BaseSku);

I have found an issue witht he product image size.

If your product image is large, it distorts the catalog list.

So there needs to be some smarts in either the cataloglist.ascx to resize the image, or when an image is uploaded, a thumb nail is created for display in the cataloglist.ascx.

Cheers

Hugh